Skip to content

Conversation

youkidearitai
Copy link
Contributor

I forgot to add a NEWS entry.
cc @alexdowad

youkidearitai referenced this pull request Sep 11, 2024
I fixed from strcasecmp to strncasecmp.
However, strncasecmp is specify size to #3 parameter.
Hence, Add check length to mime and aliases.

Co-authored-by: Niels Dossche <[email protected]>
Co-authored-by: Niels Dossche <[email protected]>
@cmb69
Copy link
Member

cmb69 commented Sep 11, 2024

This is fix is not in PHP 8.4.0beta5 (that already had been tagged earlier), so should be moved to the respective section (8.4.0RC1). Also, the subsections (MBString, etc.) should be in alphabetic order.

@youkidearitai
Copy link
Contributor Author

@cmb69 I see. Thank you. Fixed.

@cmb69 cmb69 merged commit ee715d2 into php:master Sep 11, 2024
2 of 3 checks passed
@cmb69
Copy link
Member

cmb69 commented Sep 11, 2024

Oh, forgot: thank you!

@youkidearitai youkidearitai deleted the fix-gh-15824-news-only branch September 11, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants